fix: use memfs for ts artifacts to prevent mtime conflict #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnyreilly
approved these changes
May 18, 2021
piotr-oles
commented
May 18, 2021
piotr-oles
force-pushed
the
fix/use-memfs-for-artifacts
branch
from
02426ec to
5c75f44
Compare
When ts-loader uses projectReferences mode, it writes down .js and .d.ts files. If it does it faster than the plugin, the typescript instance in the plugin is confused and doesn't work properly. To fix that, let's use memfs for dirs and files that are detected as a project artifacts.
piotr-oles
force-pushed
the
fix/use-memfs-for-artifacts
branch
from
5c75f44 to
a24fe1c
Compare
|
🎉 This PR is included in version 6.2.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 7.0.0-alpha.15 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ts-loader uses project references mode, it writes down .js and .d.ts files. If it does it faster than the plugin, the typescript instance in the plugin is confused and doesn't work properly. To fix that, let's use memfs for dirs and files that are detected as project artifacts.
Related: #611